search

nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.
GNU General Public License v2.0
172 stars 86 forks source link

operator: Add placeholder for kube-rbac-proxy #1244

Closed qinqon closed 1 month ago

qinqon commented 1 month ago

Is this a BUG FIX or a FEATURE ?:

/kind bug

What this PR does / why we need it: At some deployments the kube-rbac-proxy is different from the one at quay.io, this change add a new environment variable at operator deployment to configure that image.

Fixes https://issues.redhat.com/browse/OCPBUGS-33866

Special notes for your reviewer:

Release note:

Add a environment variable at operator to configure kube-rbac-proxy
mkowalski commented 1 month ago

/lgtm

mkowalski commented 1 month ago

/lgtm

qinqon commented 1 month ago

/retest

qinqon commented 1 month ago

/retest

qinqon commented 1 month ago

/approve

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)~~ [qinqon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
qinqon commented 1 month ago 
> Enter [It] should report a metrics with proper gauge increased - /tmp/knmstate/kubernetes-nmstate/test/e2e/handler/metrics_test.go:67 @ 06/04/24 13:00:03.362
./cluster/kubectl.sh exec -n monitoring prometheus-k8s-0 -c prometheus -- cat /var/run/secrets/kubernetes.io/serviceaccount/token
stdout: ...,
stderr: selecting podman as container runtime
error: unable to upgrade connection: container not found ("prometheus")

[FAILED] Unexpected error:
    <*errors.errorString | 0xc000cd8030>: 
    ./cluster/kubectl.shexec -n monitoring prometheus-k8s-0 -c prometheus -- cat /var/run/secrets/kubernetes.io/serviceaccount/token : selecting podman as container runtime
    error: unable to upgrade connection: container not found ("prometheus")
     exit status 1
    {
        s: "./cluster/kubectl.shexec -n monitoring prometheus-k8s-0 -c prometheus -- cat /var/run/secrets/kubernetes.io/serviceaccount/token : selecting podman as container runtime\nerror: unable to upgrade connection: container not found (\"prometheus\")\n exit status 1",
    }
occurred
mkowalski commented 1 month ago

/lgtm