search

nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.
GNU General Public License v2.0
172 stars 86 forks source link

e2e: don't require empty starting state for bridge mappings #1248

Closed mkowalski closed 1 month ago

mkowalski commented 1 month ago

This commit changes the behaviour of the OVN bridge mapping test so that we do not require the initial state to be empty. Thanks to this we make e2e tests working correctly on machines whre OVN is already used and bridges are deployed.

Without this change the test will pass only if no OVN bridge mappings exist on the node. The assumption is quite strong and not really desired.

Release note:

NONE
mkowalski commented 1 month ago

/test pull-kubernetes-nmstate-e2e-handler-k8s-future

mkowalski commented 1 month ago

/test pull-kubernetes-nmstate-e2e-handler-k8s-future

qinqon commented 1 month ago

/lgtm /approve

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)~~ [qinqon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment