search

nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.
GNU General Public License v2.0
188 stars 90 forks source link

openshift: Use handler namespace for cleanup #1265

Closed qinqon closed 2 months ago

qinqon commented 2 months ago

Is this a BUG FIX or a FEATURE ?:

/kind bug

What this PR does / why we need it: The NMState CR has no namespace at all, to remove the obsolete cert-manager at openshift operator should use the HANDLER_NAMESPACE env var.

Release note:

Use handler namespace to remove cert-manager at openshift.
qinqon commented 2 months ago

/cc @mkowalski

qinqon commented 2 months ago

/retest

kubevirt-bot commented 2 months ago

@qinqon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-nmstate-e2e-handler-k8s-future b6a5bd51feba3d3b228391f1c1cbc3f55fb8c3d9 link false /test pull-kubernetes-nmstate-e2e-handler-k8s-future
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
mkowalski commented 2 months ago

/approve

kubevirt-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkowalski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)~~ [mkowalski] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment