search

nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.
GNU General Public License v2.0
188 stars 90 forks source link

handler: retry NodeCount change on error #1271

Closed mkowalski closed 1 month ago

mkowalski commented 1 month ago

Is this a BUG FIX or a FEATURE ?:

/kind bug

What this PR does / why we need it:

Seems like sometimes we fail when changing the node count. This change adds retry on error so that we try correctly updating the count in a slightly more aggressive way.

Special notes for your reviewer:

Release note:

handler: retry NodeCount change on error
qinqon commented 1 month ago

/lgtm /approve

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)~~ [qinqon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment