search

nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.
GNU General Public License v2.0
188 stars 90 forks source link

managed-by label of nmstate-ca secret is wrong #882

Closed RamLavi closed 1 month ago

RamLavi commented 3 years ago

What happened: the managed-by label value of self deployed objects should not be inherited from CNAO/HCO CR.

$ kubectl get secret nmstate-ca -n kubevirt-hyperconverged -o custom-columns="":.metadata.labels

map[
app.kubernetes.io/component:network 
app.kubernetes.io/managed-by:hco-operator 
app.kubernetes.io/part-of:hyperconverged-cluster 
app.kubernetes.io/version:1.6.0
]

What you expected to happen: It must be app.kubernetes.io/managed-by: kubernetes-nmstate-webhook (pretty sure it's the webhook, right?)

How to reproduce it (as minimally and precisely as possible): deploy HCO/CNAO and take a look at the secret label.

Anything else we need to know?: similar to issue opened on CNAO https://github.com/kubevirt/cluster-network-addons-operator/issues/1051 Environment:

oshoval commented 2 years ago

Note please that are more entities such as enactments that are created by nmstate, so they need to be updated as well. Generally speaking we need to find and fix it for all the elements that were not directly deployed by CNAO