A strange error: the sum of the seg_ph_count is one more than the number of h_ph.

nmt28 / C-SHELPh

Apache License 2.0

13 stars 6 forks source link

A strange error: the sum of the seg_ph_count is one more than the number of h_ph. #16

Open cugsunjie opened 7 months ago

cugsunjie commented 7 months ago

During the test, we found a problem that sometimes the number of h_ph is not equal to the sum of the seg_ph_count for the same track, the sum of the seg_ph_count is always one more than the number of h_ph. Different length may lead to an error for dataframe construction. Is there any suggestion?

nmt28 commented 7 months ago

Thanks for reporting this. I have heard about this elsewhere. It likely comes from my interpolation. Until I can look into this in more detail, you can remove one photon from the end of the seg_ph_count.

If I understand correctly, this should remedy the problem until I can look at it in more detail

nmt28 commented 5 months ago

@petebunting - this issue was flagged here. I have contacted the IS2 team about it.

@cugsunjie - There is currently a 'hack' fix in the latest version. It aslso has some better error handling etc. There are also some enhancements around installation