nmullaney / candash

A simple Android app that turns your phone into an instrument cluster for your Tesla Model 3 and Y
https://candash.app
MIT License
75 stars 23 forks source link

Keep screen on #6

Closed vekexasia closed 1 year ago

vekexasia commented 2 years ago

I'm using a custom mount with no power cord to try rthis out.

I would suggest to use android:keepScreenOn="true" on the https://github.com/osunick/candash/blob/main/android/app/src/main/res/layout/activity_fullscreen.xml

Since most people would not want their screen to turn off if the app is open.

Alternatively if you feel someone would not want this feature it could be a new pref in the settings allowing the end-user to eventually decide if they want or not the flag toggled.

osunick commented 2 years ago

The main reason it behaves this way is so that it will power down when the car sleeps, as my goal was an experience that didn't need any interaction if you wanted to leave it alone, and I'll think about changing this behavior when I do feature work again, but as a non default pref.

On Sat, Feb 19, 2022, 9:06 AM Andrea @.***> wrote:

I'm using a custom mount with no power cord to try rthis out.

I would suggest to use android:keepScreenOn="true" on the https://github.com/osunick/candash/blob/main/android/app/src/main/res/layout/activity_fullscreen.xml

Since most people would not want their screen to turn off if the app is open.

Alternatively if you feel someone would not want this feature it could be a new pref in the settings allowing the end-user to eventually decide if they want or not the flag toggled.

— Reply to this email directly, view it on GitHub https://github.com/osunick/candash/issues/6, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD72K5Y4HFSON72ALCPE2LU37E2ZANCNFSM5O2YKA6A . You are receiving this because you are subscribed to this thread.Message ID: @.***>

vekexasia commented 2 years ago

It could also work this way. If car is in "P" then setscreenalwayson to false. If car is in drive then set it to true?

Il sab 19 feb 2022, 19:20 Nick Nguyen @.***> ha scritto:

The main reason it behaves this way is so that it will power down when the car sleeps, as my goal was an experience that didn't need any interaction if you wanted to leave it alone, and I'll think about changing this behavior when I do feature work again, but as a non default pref.

On Sat, Feb 19, 2022, 9:06 AM Andrea @.***> wrote:

I'm using a custom mount with no power cord to try rthis out.

I would suggest to use android:keepScreenOn="true" on the

https://github.com/osunick/candash/blob/main/android/app/src/main/res/layout/activity_fullscreen.xml

Since most people would not want their screen to turn off if the app is open.

Alternatively if you feel someone would not want this feature it could be a new pref in the settings allowing the end-user to eventually decide if they want or not the flag toggled.

— Reply to this email directly, view it on GitHub https://github.com/osunick/candash/issues/6, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAD72K5Y4HFSON72ALCPE2LU37E2ZANCNFSM5O2YKA6A

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/osunick/candash/issues/6#issuecomment-1046076710, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABQ6S7SCEN4WNY4KLH6EFDU37NQBANCNFSM5O2YKA6A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

osunick commented 2 years ago

That's a really good idea. I'll implement that it a bit.

On Sat, Feb 19, 2022, 1:05 PM Andrea @.***> wrote:

It could also work this way. If car is in "P" then setscreenalwayson to false. If car is in drive then set it to true?

Il sab 19 feb 2022, 19:20 Nick Nguyen @.***> ha scritto:

The main reason it behaves this way is so that it will power down when the car sleeps, as my goal was an experience that didn't need any interaction if you wanted to leave it alone, and I'll think about changing this behavior when I do feature work again, but as a non default pref.

On Sat, Feb 19, 2022, 9:06 AM Andrea @.***> wrote:

I'm using a custom mount with no power cord to try rthis out.

I would suggest to use android:keepScreenOn="true" on the

https://github.com/osunick/candash/blob/main/android/app/src/main/res/layout/activity_fullscreen.xml

Since most people would not want their screen to turn off if the app is open.

Alternatively if you feel someone would not want this feature it could be a new pref in the settings allowing the end-user to eventually decide if they want or not the flag toggled.

— Reply to this email directly, view it on GitHub https://github.com/osunick/candash/issues/6, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AAD72K5Y4HFSON72ALCPE2LU37E2ZANCNFSM5O2YKA6A

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/osunick/candash/issues/6#issuecomment-1046076710, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AABQ6S7SCEN4WNY4KLH6EFDU37NQBANCNFSM5O2YKA6A

. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/osunick/candash/issues/6#issuecomment-1046102330, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD72K42PI7DPH7CLM3KHR3U4AAX5ANCNFSM5O2YKA6A . You are receiving this because you commented.Message ID: @.***>

osunick commented 1 year ago

Closed because @carleeno implemented a better version of this idea.