nmunson / warmup-reps

Calculate warmup sets, reps and weights for strength training programs like Starting Strength.
http://WarmupReps.com
72 stars 28 forks source link

Update sets on slider input change using arrows #15

Open jdmartinez opened 8 years ago

jdmartinez commented 8 years ago

Warmup sets don't update when weight is changed using input arrow buttons. In a desktop browser you have to click elsewhere to update sets.

nmunson commented 4 years ago

@jdmartinez thanks for this PR. When testing it I see that it does correctly fix the problem you described, but it hurts the performance of using the slider when dragging and dropping. I think it's trying to calculate each intermediate step before dropping the slider. Let me know if you have ideas about fixing that or I can close this PR out.