search

nmwsharp / navigating-intrinsic-triangulations-demo

Demo code for "Navigating Intrinsic Triangulations". Sharp, Soliman, and Crane. 2019
MIT License
47 stars 8 forks source link

Build is broken with current version of geometry-central #2

Open keenancrane opened 4 years ago

keenancrane commented 4 years ago

Following the instructions in README.md, Cmake fails to build the final executable:

[ 95%] Building CXX object deps/polyscope/src/CMakeFiles/polyscope.dir/curve_network_vector_quantity.cpp.o
[ 96%] Linking CXX static library ../../../lib/libgeometry-central.a
[ 96%] Built target geometry-central
[ 97%] Linking CXX static library ../../../lib/libpolyscope.a
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: ../../../lib/libpolyscope.a(trace_vector_field.cpp.o) has no symbols
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: ../../../lib/libpolyscope.a(trace_vector_field.cpp.o) has no symbols
[ 97%] Built target polyscope
Scanning dependencies of target int_tri
make[2]: *** No rule to make target `../deps/geometry-central/deps/-lm', needed by `bin/int_tri'.  Stop.
make[2]: *** Waiting for unfinished jobs....
[ 98%] Building CXX object CMakeFiles/int_tri.dir/src/main.cpp.o
make[1]: *** [CMakeFiles/int_tri.dir/all] Error 2
make: *** [all] Error 2
nmwsharp commented 4 years ago

Hm, I couldn't reproduce this on a few different machines (doesn't mean there's not a problem though!). This happened even with a fresh clone of the repo?

I have a very vague memory of fixing an error like this once before on some other project, but I can't remember the situation.... perhaps some compile flag was getting set in a way that caused it to be interpreted as a target? I can't recall.

Regardless, I just updated the dependencies of this repo to point to their current master versions. Could you give it another try and tell me if the issue persists?