nmwsharp / potpourri3d

An invigorating blend of 3D geometry tools in Python.
MIT License
414 stars 31 forks source link

Add PointCloudLocalTriangulation interface #11

Closed lkskstlr closed 1 year ago

lkskstlr commented 1 year ago
Add class in src/point_cloud.cpp
Expose class in point_cloud.py
Add test based on cartwheel pointcloud
lkskstlr commented 1 year ago

Dear @nmwsharp,

thanks again for your amazing work.

As discussed, here is the pull request. The test is based on a cartwheel pointcloud (see image).

I thought that you maybe have a better idea of how you would want this functionality to be referenced in the main README and hence did not do this.

Cheers Lukas

Point cloud used for the test with local triangulation

local_triangulation

nmwsharp commented 1 year ago

I made one small comment above, but otherwise this looks good-to-go. Thank you for contributing!

nmwsharp commented 1 year ago

Merged! Thanks again :)

I also added some quick "docs" in the README so perhaps others can find the new function.

I pushed the new build; as long as nothing goes wrong it should be available on the package managers by tomorrow. Please follow up if anything seems wrong.

lkskstlr commented 1 year ago

Thanks :)