search

nmwsharp / potpourri3d

An invigorating blend of 3D geometry tools in Python.
MIT License
414 stars 31 forks source link

Add Geodesic Trace Function #15

Closed zalo closed 2 months ago

zalo commented 7 months ago

This PR exposes the Geodesic Trace Function, which I'm interested in using to wrap LED Strips around various shapes 😅

nmwsharp commented 7 months ago

Thanks! Happy to have this added :)

Is there any reason why you added it as a member of EdgeFlipSolver rather than a standalone function?

zalo commented 7 months ago

Ah, good shout; not sure why I thought it was in the same class of Algorithms; I'll break it out.

Also, while I have you here, is there a reasonable way to make a SurfacePoint from a cartesian point (via nearest-triangle/edge/vertex search)?

nmwsharp commented 2 months ago

Thank you for this! I adapted it in d1db3bb8fbcc8507f90bfbe9194487073e5fab96. New version will be coming soon. I made a few small changes, most importantly taking the direction as xyz world coordinates, since its not simple for users how to get tangent coordinates.

nmwsharp commented 2 months ago

P.S. I forgot to do it on that one, but I also added you as a coauthor on the next commit so you don't get robbed of showing up as a contributor :)