nna-rivers / CTSM

CTSM Fork for NNA-Rivers Project
http://www.cesm.ucar.edu/models/cesm2.0/land/
Other
0 stars 2 forks source link

Hh.ppe.n08 ctsm5.1.dev023 #9

Closed YifanCheng closed 2 years ago

YifanCheng commented 2 years ago

Description of changes

This pull request mainly includes two changes: 1) we used the default natural pft instead of using prescribed pft from hillslope hydrology 2) add two spatially distributed parameters - a_exp and liq_canopy_storage_scalar

Specific notes

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)?

Any User Interface Changes (namelist or namelist defaults changes)?

Testing performed, if any: (List what testing you did to show your changes worked as expected) (This can be manual testing or running of the different test suites) (Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide) (aux_clm on cheyenne for intel/gnu and izumi for intel/gnu/nag/pgi is the standard for tags on master)

NOTE: Be sure to check your coding style against the standard (https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review the list of common problems to watch out for (https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).

apcraig commented 2 years ago

I have run a test suite on cheyenne with these changes and everything looks good. The answers are different (expected) but otherwise everything builds and runs, exact restart is also still working. I will approve and merge.