nnaisense / evotorch

Advanced evolutionary computation library built directly on top of PyTorch, created at NNAISENSE.
https://evotorch.ai
Apache License 2.0
997 stars 62 forks source link

Fix the interface of `make_I` #62

Closed engintoklu closed 1 year ago

engintoklu commented 1 year ago

The function evotorch.tools.make_I was accepting a single integer as the size indicator of the identity matrix. However, the method Problem.make_I was working only when the size was given as a single-element tuple. This pull request makes their interfaces compatible by making isure that both will work with a single integer or with a size tuple containing a single integer. Tests are updated to verify the correctness of the revised interfaces.

flukeskywalker commented 1 year ago

👍🏽

codecov-commenter commented 1 year ago

Codecov Report

Merging #62 (5c7d266) into master (aa57024) will increase coverage by 0.11%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   77.74%   77.86%   +0.11%     
==========================================
  Files          49       49              
  Lines        7321     7329       +8     
==========================================
+ Hits         5692     5707      +15     
+ Misses       1629     1622       -7     
Impacted Files Coverage Δ
src/evotorch/algorithms/cmaes.py 82.94% <100.00%> (ø)
src/evotorch/distributions.py 81.16% <100.00%> (-0.07%) :arrow_down:
src/evotorch/tools/misc.py 86.42% <100.00%> (+0.06%) :arrow_up:
src/evotorch/tools/tensormaker.py 94.59% <100.00%> (+6.02%) :arrow_up:
src/evotorch/core.py 74.55% <0.00%> (+0.07%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.