nnarain / gameboycore-python

Python Bindings for GameboyCore
MIT License
5 stars 2 forks source link

Improve Git workflow #18

Closed nnarain closed 6 years ago

nnarain commented 6 years ago

Git workflow needs improvement.

Builds fail when pushing to master because commits on the master branch trigger CI pushes to PyPi which fail because the setup.py version isn't bumped.

max-vogler commented 6 years ago

Hey @nnarain!

You probably already evaluated this option, but just in case you haven't: Instead of having two branches, Travis can also push to PyPI only on tagged commits. You can achieve this by adding the following to your build stage in .travis-ci.yml:

  on:
    tags: true

Doing this you wouldn't need to add another branch.

nnarain commented 6 years ago

I've been thinking about different git workflows and that option totally slipped my mind. I use in gameboycore.

Thanks!