search

nnattawat / flip

A lightweight jQuery plugin to make 3D card flipping animation
Other
627 stars 312 forks source link

v1.0.11 Not working in Firefox #28

Closed rembo10 closed 9 years ago

rembo10 commented 9 years ago

Hey - I was using the v1.0.10 release and it was working fine but the new version is broken in Firefox (works in chrome).

I get 'ReferenceError: event is not defined' when clicking on the card

Happens even when I try the demo flip at the top of http://nnattawat.github.io/flip/

JemarJones commented 9 years ago

Could you please show this in a JSfiddle if its easy enough to replicate?

Edit: Oops nvm i see that it exists on the demo.

rembo10 commented 9 years ago

https://jsfiddle.net/xtrw02px/

rembo10 commented 9 years ago

Oh yeah - I basically just copied that example :-)

rembo10 commented 9 years ago

I think I might have been using the v1.0.1 release also..... not v1.0.10.... i installed flip through bower and i think it pulled from this repo and not the Download repo, and i just tried to update a few hours ago (like, right after the project was merged back).... sorry for the confusion - I wasn't sure what was going on

JemarJones commented 9 years ago

Yea this issue seems to date back to at least 1.0.4, before i started contributing. I'll keep looking to try to figure this out though.

JemarJones commented 9 years ago

Appears to be specific to to the click trigger, not an issue with manual or hover.

Sorta just taking notes here ahah.

rembo10 commented 9 years ago

Cool thanks! On Jul 13, 2015 5:43 PM, "Jemar Jones" notifications@github.com wrote:

Yea this issue seems to date back to at least 1.0.4, before i started contributing. I'll keep looking to try to figure this out though.

— Reply to this email directly or view it on GitHub https://github.com/nnattawat/flip/issues/28#issuecomment-121099687.

JemarJones commented 9 years ago

Okay so i've now fixed this issue. Unfortunately i haven't been given push access to the main repo yet and do not know how to build a release myself. For now i've pushed my fix to the @Download fork here https://github.com/Download/flip/commit/a62b8f6376704aa5222ba0417927b3b23e0687bc, and we'll have to wait for him to build the release and pull the changes up here.

Thanks for spotting this!

Edit: Scratch that, i'm now a Collaborator. Thanks @nnattawat!

rembo10 commented 9 years ago

Not to worry. 1.0.1 works fine for me for the time being On Jul 13, 2015 5:57 PM, "Jemar Jones" notifications@github.com wrote:

Okay so i've now fixed this issue. Unfortunately i haven't been given push access to the main repo yet and do not know how to build a release myself. For now i've pushed my fix to the @Download https://github.com/Download fork here Download@a62b8f6 https://github.com/Download/flip/commit/a62b8f6376704aa5222ba0417927b3b23e0687bc, and we'll have to wait for to build the release and pull the changes up here.

Thanks for spotting this!

— Reply to this email directly or view it on GitHub https://github.com/nnattawat/flip/issues/28#issuecomment-121102139.

Download commented 9 years ago

Fixed in v1.0.12. Please re-open if you still have issues.