search

nnattawat / flip

A lightweight jQuery plugin to make 3D card flipping animation
Other
624 stars 312 forks source link

Refactor #85

Closed nnattawat closed 8 years ago

nnattawat commented 8 years ago

Wrap all APIs into Object and attach to DOM as .data('flip-model')

JemarJones commented 8 years ago

Can you give an overview of all the API changes/ use cases that result from this?

nnattawat commented 8 years ago

As the code base have been added/modified quite a lot, I just find it is quite difficult to read and debug especially those very long nested if/else statements. I think it's time to refactor it a bit by separating them into small methods so that anyone can understand code by skimming quickly. It's a good starting point for me to have a look at existing issues and it also makes it more easier to get contributed.

PS: All features are kept the same and been tested thoroughly 😄

JemarJones commented 8 years ago

Oh okay i see, looks good to me then 👍