search

nnev / c128-kasse

Kassensoftware für den C128
Other
3 stars 3 forks source link

itemz does not use new € sign #18

Closed sur5r closed 2 years ago

sur5r commented 6 years ago

I just updated the floppy with current master and found itemz not to be using the new € sign. I have no time to fix it myself, though.

stapelberg commented 2 years ago

This is what it looks like to me right now:

itemz

Is that not the correct € sign? It looks the same to me like in the kasse main program.

sur5r commented 2 years ago

Maybe this behaves inconsistently for some reason on real hardware. Will have to try.

stapelberg commented 2 years ago

Ah, I think the problem might be that the itemz program does not call https://github.com/nnev/c128-kasse/blob/7ac9f791f891aea4a1b00862d56bc3ad90f8db72/src/kasse.c#L307 when starting.

When autostarting the kasse disk image (like we do in make vice), the character set is modified and that influences the itemz program, too.

But, when changing -autostart kasse.d71 to -8 kasse.d71 and running run"itemz, I see a broken euro symbol indeed: euro

I have been thinking about merging itemz into kasse, so that we only need the one program. Was there any reason against that, or have we just never gotten around to doing it? (We did something similar for the credit manager AFAIR.)

sur5r commented 2 years ago

I think we simply never got around to it. Also, modifying items while running kasse could have interesting side effects. The data model also does not cope with prices changing over time. At least the sum is going to be wrong.

stapelberg commented 2 years ago

I think commit 62aba6cbe653d049d96266127b63e629fd01346c should do it :)

We’re re-loading the items file after running the itemz_manager() function.

sur5r commented 2 years ago

Makes sense at a first glance. Should be tested before the event, though.