nnev / frank

Frank is an IRC bot written in Go. It’s my pet project to learn Go and specifically tailored to my needs.
ISC License
8 stars 7 forks source link

Making frank go-vet clean #50

Closed ghost closed 5 years ago

ghost commented 5 years ago

These changes clean up the following messages, reported by 'go vet':

./frank.go:48: Fatal call has possible formatting directive %v ./frank.go:79: Fatal call has possible formatting directive %v ./frank.go:143: Printf format %s arg parsed.Trailing is a func value, not called ./members.go:16: initChannel passes lock by value: main.membersMap contains sync.RWMutex ./members.go:22: add passes lock by value: main.membersMap contains sync.RWMutex ./members.go:27: remove passes lock by value: main.membersMap contains sync.RWMutex ./members.go:32: rename passes lock by value: main.membersMap contains sync.RWMutex ./members.go:42: IsMember passes lock by value: main.membersMap contains sync.RWMutex ./urifind.go:297: io.LimitedReader composite literal uses unkeyed fields ./urifind_test.go:175: T.Errorf format %s has arg secs of wrong type int