search

nnev / kzeen-wo-ist-die-pizza

pizza <3 | UNMAINTAINED / ABANDONED, pls see pizza4c
ISC License
5 stars 1 forks source link

basic ingredients need prefix #3

Open breunigs opened 6 years ago

breunigs commented 6 years ago

Basic ingredients are usually part of some menu (think Pizza + Drink + Salad, or Pizza Calzone with free ingredients). Especially in the former case it's not entirely clear how to print these extra ingredients.

Consider the "2 kleine Pizza" menu:

2 kleine Pizza
     1. Apfelschorle
     2. BBQ-Sauce + Ei
     3. Ei + Kapern
     4. Joghurt Dressing

It consists of a drink, two pizzas with two ingredients each, and a salad. Original JSON link: ask on IRC (/edit)

A better display would be:

Menü: 2 kleine Pizza
     * Getränk: Apfelschorle
     * 1. Pizza: BBQ-Sauce + Ei
     * 2. Pizza: Ei + Kapern
     * Salat: Joghurt Dressing

The Menü could be taken from the category and is available in the JSON files. However, there is no "prefix" for each of the base ingredients in their API, just some instructions for the user, e.g. Wählen Sie 2 Zutaten für 2. Pizza.

A possible solution could be to use a hard coded mapping from that description to a shorter 'prefix' and bail whenever such a description cannot be parsed. A good place to start would be app/models/remote/product.rb, but we would need to ensure all descriptions are read when using the rake retriever:refresh task. Also all views would need to be updated (own basket, group table, PDF, …)

sur5r commented 6 years ago

An alternative to mapping from the description could be mapping from the basic ingredient group ID. Manual comparison across some products suggests they are used in a consistent way.

Example:

10200 -> Getränk
10205 -> 1. Pizza
10206 -> 2. Pizza
10207 -> Zwangsdressing
10211 -> Dressing