Open breunigs opened 6 years ago
An alternative to mapping from the description could be mapping from the basic ingredient group ID. Manual comparison across some products suggests they are used in a consistent way.
Example:
10200 -> Getränk
10205 -> 1. Pizza
10206 -> 2. Pizza
10207 -> Zwangsdressing
10211 -> Dressing
Basic ingredients are usually part of some menu (think Pizza + Drink + Salad, or Pizza Calzone with free ingredients). Especially in the former case it's not entirely clear how to print these extra ingredients.
Consider the "2 kleine Pizza" menu:
It consists of a drink, two pizzas with two ingredients each, and a salad. Original JSON link: ask on IRC (/edit)
A better display would be:
The
Menü
could be taken from the category and is available in the JSON files. However, there is no "prefix" for each of the base ingredients in their API, just some instructions for the user, e.g.Wählen Sie 2 Zutaten für 2. Pizza
.A possible solution could be to use a hard coded mapping from that description to a shorter 'prefix' and bail whenever such a description cannot be parsed. A good place to start would be
app/models/remote/product.rb
, but we would need to ensure all descriptions are read when using therake retriever:refresh
task. Also all views would need to be updated (own basket, group table, PDF, …)