nnguyen259 / KuroTools

Tools for working with Kuro no Kiseki .dat and .tbl files
MIT License
33 stars 7 forks source link

Problems Compiling the .dat File for Ys X: Nordics Demo #40

Open Digote opened 1 month ago

Digote commented 1 month ago

First, congratulations on this tool! I've been testing it, and it works perfectly. The engine for this game is quite complicated to work with, so I really appreciate your effort.

Regarding the issue, it seems to be a simple one related to extra quotation marks in the text. If these extra quotation marks are removed, the file compiles normally. I've also tested it in-game, and it works fine.

I’ll attach a file that exhibits this issue. I’ve tried with other files and encountered the same problem.

I’ll also include the .py file and point out the specific lines where the problem occurs:

mp_s0001_dat.zip

mp_s0001_py.zip

Thank you!

Kyuuhachi commented 2 days ago

This line should just use repr(). https://github.com/nnguyen259/KuroTools/blob/4f09c36c960ee74f75764f46a5008a4f8e227ba9/disasm/ED9Disassembler.py#L999