nnicandro / emacs-zmq

Emacs bindings to ØMQ
GNU General Public License v2.0
49 stars 18 forks source link

Wrong api address for 'Check for compatible module binary to download?' #23

Closed dalanicolai closed 4 years ago

dalanicolai commented 4 years ago

Because the repository has moved the api-call to look for binaries is broken.

Using the old api address with curl:

curl   -H "Accept: application/vnd.github.v3+json" https://api.github.com/repos/dzop/emacs-zmq/releases/v0.10.10

{
  "message": "Moved Permanently",
  "url": "https://api.github.com/repositories/133400325/releases/v0.10.10",
  "documentation_url": "https://docs.github.com/v3/#http-redirects"
}

With the new address:

curl -H "Accept: application/vnd.github.v3+json" https://api.github.com/repos/nnicandro/emacs-zmq/releases/v0.10.10

{
  "message": "Not Found",
  "documentation_url": "https://docs.github.com/rest/reference/repos#get-a-release"
}
nnicandro commented 4 years ago

Thanks, I fixed it.

dalanicolai commented 4 years ago

Great!

dalanicolai commented 4 years ago

It seems like this is not yet fixed. You should look more carefully to the curl commands that I wrote in the original issue. It looks like just changing the 'dzop' to 'nnicandro' in the URL does not fix it.