nning / protonutils

CLI tool providing utilities for Proton: List games by version, Download/update GE/Luxtorpeda, clean unused runtimes, clean unused compatdata, ...
MIT License
36 stars 0 forks source link

"appid" does not recognize -u option #7

Closed L1Q closed 2 years ago

L1Q commented 2 years ago
[l1q@l1q-mj ~]$ protonutils appid "Muck"
Warning: Several Steam users available, using 69221152
All available users: 69221152, 82996121
Option "-u" can be used to specify user

[l1q@l1q-mj ~]$ protonutils appid "Muck" -u 82996121
Error: unknown shorthand flag: 'u' in -u
Usage:
  protonutils appid [flags]

Flags:
  -h, --help   help for appid

[l1q@l1q-mj ~]$ protonutils appid -u 82996121  "Muck" 
Error: unknown shorthand flag: 'u' in -u
Usage:
  protonutils appid [flags]

Flags:
  -h, --help   help for appid

[l1q@l1q-mj ~]$ protonutils -u 82996121 appid "Muck" 
Error: unknown shorthand flag: 'u' in -u
Usage:
  protonutils appid [flags]

Flags:
  -h, --help   help for appid

[l1q@l1q-mj ~]$
nning commented 2 years ago

The -u option has the be used after the command name, as in the following command, for example:

protonutils appid -u 82996121 Muck
L1Q commented 2 years ago

protonutils appid -u 82996121 Muck

Still does not work. Retesting with v1.2.8 and the -u behaviour is the same:

[l1q@l1q-mj ~]$ protonutils appid Muck
Warning: Several Steam users available, using 69221152
All available users: 69221152, 82996121
Option "-u" can be used to specify user

1625450   Muck
[l1q@l1q-mj ~]$ protonutils appid -u 82996121 Muck
Error: unknown shorthand flag: 'u' in -u
Usage:
  protonutils appid [flags]

Flags:
  -h, --help   help for appid

[l1q@l1q-mj ~]$ protonutils version
v1.2.8 20211129163704 https://github.com/nning/protonutils/tree/v1.2.8
[l1q@l1q-mj ~]$
L1Q commented 2 years ago

Same issue exists for compatdata command

[l1q@l1q-mj ~]$ protonutils compatdata path Muck
Warning: Several Steam users available, using 69221152
All available users: 69221152, 82996121
Option "-u" can be used to specify user

/home/l1q/.local/share/Steam/steamapps/compatdata/1625450
[l1q@l1q-mj ~]$ protonutils compatdata path -u 82996121 Muck
Error: unknown shorthand flag: 'u' in -u
Usage:
  protonutils compatdata path [flags]

Flags:
  -h, --help   help for path

[l1q@l1q-mj ~]$
nning commented 2 years ago

Thanks very much for testing and finding this bug! I actually forgot to properly wire the -u (and -c) option to the appid and compatdata commands. The issue is fixed in the referenced commit and I will include the fix in the next release.

A CI build to test this change can be found at the following location, if you want to test: https://github.com/nning/protonutils/suites/4498677223/artifacts/120023982

(Please close this issue, if it's fixed for you!)

L1Q commented 2 years ago

Yep, fixed in the CI build.