nnja / python

Front End Masters Python - Course Website at https://learnpython.dev
https://learnpython.dev
MIT License
443 stars 224 forks source link

Add language label only if class attribute exists #85

Closed hangindev closed 4 years ago

hangindev commented 4 years ago

The app breaks if any of the $('pre code') tags doesn't have a class attribute. For example https://www.learnpython.dev/02-introduction-to-python/060-functions/30-function-arguments/

I change the code to be more forgiving so that it will not break which fixes #80.

nnja commented 4 years ago

Good eye! Thank you so much for your contribution.

hangindev commented 4 years ago

Thank you for your courses! Looking forward to "A Practical Guide to Python".

P.S. sorry you had to deal with all those spammy PRs.

nnja commented 4 years ago

Thank you for your courses! Looking forward to "A Practical Guide to Python".

P.S. sorry you had to deal with all those spammy PRs.

I only had a handful of PRs to close -- definitely not as bad as other projects!

I hope to see you at a Practical Guide to Python, but wanted to give you a heads up that the content will be quite similar to this two day workshop. Instead of focusing on folks who are absolute beginners to programming, Practical Python will condense two days of material into one, focusing on developers who know another language and are looking to get productive with Python as quickly as possible.