search

nnjeim / world

A Laravel package which provides a list of the countries, states, cities, currencies, timezones and languages.
MIT License
737 stars 104 forks source link

Remove states of Singapore #46

Closed pengkong closed 1 year ago

pengkong commented 1 year ago

Could I suggest that for the country of Singapore we remove this 5 states:

https://github.com/nnjeim/world/blob/master/resources/json/states.json#L39207

Reason: Singapore is tiny (smaller then New York City) and is itself a city-state. So strictly speaking Singapore has no states.

nnjeim commented 1 year ago

@pengkong It seems that the listed states are in reality regions or districts of the city itself. https://en.wikipedia.org/wiki/Regions_of_Singapore Please feel free to submit a PR removing the states. Thank you for your contribution.

Screenshot 2023-03-08 at 07 26 15

nnjeim commented 1 year ago

@pengkong thank you for your contribution. please pull tag 1.1.21