search

nnjeim / world

A Laravel package which provides a list of the countries, states, cities, currencies, timezones and languages.
MIT License
737 stars 104 forks source link

Bulk insert queries #55

Closed mrmmg closed 1 year ago

mrmmg commented 1 year ago

Based on issue #54 I changed the seeder private class to insert bulk queries instead of running a single query in a for-each loop. With these changes on my localhost setup, the seed actions take about 3 minutes to complete.

nnjeim commented 1 year ago

@mrmmg hi, i have tested your modification, the performance increase is amazing! thank you. Please merge.

mrmmg commented 1 year ago

@mrmmg hi, i have tested your modification, the performance increase is amazing! thank you. Please merge.

You're welcome

I think you should merge my PR into master, or I change the master branch on my fork then submit another PR. am I think right?