search

nnjeim / world

A Laravel package which provides a list of the countries, states, cities, currencies, timezones and languages.
MIT License
737 stars 104 forks source link

Laravel 10 - lang directory location is changed #68

Closed stefanrakicfaxi closed 8 months ago

stefanrakicfaxi commented 8 months ago

Describe the bug After installing a package my localization stopped working and I couldn't find what's the problem. After a few hours, I saw what is the problem, this package overridden the complete location for reading localization and after moving my files to resources/lang started working again but that is not a good solution please fix the bug so we can keep the lang directory in the root because other packages trying to load localization from original location.

nnjeim commented 8 months ago

@stefanrakicfaxi thank you for the input. can you please technically describe the problem ? show the part of the code conflicting with your other package?

stefanrakicfaxi commented 8 months ago

For example, I use this package https://github.com/rmariuzzo/Laravel-JS-Localization that does not support Laravel 10 yet, I overrode some classes and now that's working but this package reads localization from the lang directory from the root. I use filament too and when I publish localization files by default they are published in the lang directory in root. Probably all other packages do the same. And on the end is very danger to some 3rd party packages to override the path for the lang directory for the whole app