search

nnmatveev / idea-plugin-protobuf

Google Protocol Buffes support for Intellij IDEA
Other
120 stars 39 forks source link

Allow setting the option --proto_path #46

Open mwtaylor opened 11 years ago

mwtaylor commented 11 years ago

It would be nice to allow setting the protobuf compiler option --proto_path through the facet settings. This path should also be used when doing syntax highlighting to determine valid imports.

tcripps commented 11 years ago

Just for reference, from https://developers.google.com/protocol-buffers/docs/proto?hl=en:

The protocol compiler searches for imported files in a set of directories specified on the protocol compiler command line using the -I/--proto_path flag. If no flag was given, it looks in the directory in which the compiler was invoked. In general you should set the --proto_path flag to the root of your project and use fully qualified names for all imports.

ajefferson commented 10 years ago

I agree with mwtaylor. It's legitimate to specify more than one path using the -I/--proto_path flag. A use case for this is if you need to import google/protobuf/descriptor.proto in order to create custom options and don't want to put the protocol compiler in your project.

bwill commented 9 years ago

this is also a problem for us. In our project, we're grouping .proto files into folders. When building the project, we build with the proto_path set to the root proto folder, but the plugin always uses the current directory, so it's not possible to get the paths right in the import statement so that both build.

sivasankariit commented 9 years ago

+1. This creates problems when grouping the .proto files based on package hierarchy.

yasserg commented 9 years ago

+1

tcripps commented 9 years ago

This was added at the project level by Boris Byk. Thanks, Boris!

ehoule commented 8 years ago

Hi, if I got this right, it seems this feature is completed... Would it be possible to make a release so this would be available (without having to do a local build)? Thanks a lot!

dattanchu commented 8 years ago

It has been a month, can we release this fix onto IntelliJ plugin repo please?

tcripps commented 8 years ago

There's a release in progress. When the other issues targeted for that release are resolved, we'll ship a new plugin version.

joeaniu commented 8 years ago

waiting the "proto_path setting" feature too. 👍

51gordon commented 8 years ago

waiting the "proto_path setting" feature too.