nnmatveev / idea-plugin-protobuf

Google Protocol Buffes support for Intellij IDEA
Other
120 stars 39 forks source link

Proto3 Not Supported #68

Closed tmazeika closed 8 years ago

tmazeika commented 9 years ago

It seems that the proto3 syntax is unsupported, as errors occur when I remove required and optional keywords, as required by proto3. While it is still in alpha, basic support for it may at least alleviate the littering of errors all over the file.

wenerme commented 9 years ago

Syntax with service not support.

syntax = "proto3";

option java_package = "play";

package play;

// The request message containing the user's name.
message HelloRequest {
    string name = 1;
}

// The response message containing the greetings
message HelloReply {
    string message = 1;
}

// The greeter service definition.
service Greeter {
    // Sends a greeting
    rpc SayHello (HelloRequest) returns (HelloReply) {}
    rpc SayHelloToThem(HelloRequest) returns (stream HelloReply) {}
    rpc SayHelloToAll(stream HelloRequest) returns (stream HelloReply) {}
}
IceMan81 commented 9 years ago

It would be nice to have support for proto3. Thanks for the work you have put in to create this plugin.

ramtej commented 9 years ago

+1 for proto3 support

akaspin commented 9 years ago

+1

flzyup commented 9 years ago

+1

mwitkow commented 9 years ago

Pretty please :)

depend commented 9 years ago

+1

kshchepanovskyi commented 9 years ago

+1

image

leebird commented 9 years ago

+1. Thanks!

IceMan81 commented 8 years ago

@tcripps Thanks a lot for this fix!

ramtej commented 8 years ago

Thanks !