search

nnmrts / starfield-efm

extended favorites menu
1 stars 0 forks source link

Correct RSL font import for `fonts_en.swf` #3

Open Scrivener07 opened 1 day ago

Scrivener07 commented 1 day ago

Once the Flash document is changed to use RSL style fonts, and a user installs a font replacer over fonts_en.swf, then EFM Favorites menu will respect it. I'm dumb. I did all the footwork for RSL font except changing Export to Import.

Proposal

Red shows the edits. The linkage should say "Import: CLASSNAME" when RSL is setup right.

capture1

Impacts

The attached video shows the consequence of a runtime shared font library. If you're testing outside the game, then the fonts_en.swf needs to be present in the same directory. This is not needed when run inside the game because the fonts_en.swf can be looked up using the game's virtual file system, which exposes the contents of the BA2 archives. Flash doesn't understand BA2 and that's why you need it present outside the game. We should not distribute the fonts_en.swf.

https://github.com/user-attachments/assets/7d5f0cd3-ebaf-4d77-9faf-d3f023d4d8d5

Changes

Although XFL is friendly with git version control, it is still not very merge friendly. Since we have a few branches, I reckon it will be easier to just make a note for the simple change here, and then upstream it into whatever branch ends up into main branch. This issue could also be referenced in the future as instructions on how to setup RSL for Flash document symbols. I marked this issue as enhancement because the embedded font still works.

Scrivener07 commented 1 day ago

I should add these details to the README.md as a Restoration step.

Scrivener07 commented 1 day ago

This was fixed with pull request #2.

Scrivener07 commented 1 day ago

I'm re-opening this because I forgot to document the restoration steps, and I don't feel like doing it at the moment. So re-open it is :)