nnmware / devoops

DevOOPS Bootstrap 3 Admin theme
GNU General Public License v3.0
852 stars 416 forks source link

Bower - package manager to js plugins #33

Closed mfdeveloper closed 9 years ago

mfdeveloper commented 9 years ago

Moved javascript plugins from folder plugins to bower_components to allow use bower install command to download this theme. After accept this merge request, you can perform:

bower install devoops-bootstrap-theme

Or add in your bower.json

"dependencies": {
    "devoops-bootstrap-theme":">=2.0"
}

Obs: Temporarilly, was added the git://github.com/mfdeveloper/devoops.git url repo. I will change this addres in bower register, after that this pull request will be finish!

nnmware commented 9 years ago

Felipe, thank for your work. But 1) We not use/know bower and node, and can't test this pull request 2) If we right understand - changed paths for many plugins, but in devoops.js no changes. With this pull request- theme not usable. Sorry.

mfdeveloper commented 9 years ago

Hello @nnmware. Thank you so much for your fast response :smile:

I understand your point. The paths in devoops.js file were updated just now! But, I don't understand because @devoopsme close this issue. If you not use bower, why do you not want use now? The dependencies management is hard today, and with bower this is so much fast and easy to use together another front-end tools (gulp, grunt...) in a application that use this theme. In few minutes, you can test my pull request easily. Just look at the getting started in official site http://bower.io/

Do you have some doubt about this? Can I help you to test this pull request?

jomo666 commented 9 years ago

Hello. Not everybody could use bower. (For example not every company allows install it). Myself can't use it too. Thank you for the great work anyway - unfortunately, with bower - it is unusable for me too.

mfdeveloper commented 9 years ago

Hello @jomo666. I understand now. My suggestions are:

  1. Create a branch or tag version with bower support. The tag version is verified automatically by bower if a bower.json file exists in this repo.
  2. Keep my fork to a bower registry website and reference my github url in this repo (can be in REAME.md file).

What do you think?

jomo666 commented 9 years ago

Thats would be great. Or just create the master with bower and together, if you could maintain a branch which doesn't depends on bower. Any approach which results "bower independency" is simply great. :) Thank you for your quick answer.

mfdeveloper commented 9 years ago

Great @jomo666. What I need to do now? The @devoopsme needs reopen this pull request, and merge this changes into a tag or add my branch bower_dependencies into this repo, no? I did others changes and commits, but I don't push to here yet. I'm waiting for a decision now :smile:

jomo666 commented 9 years ago

Huh... honestly, i'm an gitnoob and haven't idea about the process. I just commented (and concerned about) the "bower independence" - but, sorry - I haven't idea about all around. In the worst case, just ignore my comments. :) :)

devoopsme commented 8 years ago

Sorry. we don't have time for make another branches, etc. But It's open source, you can free fork code and make all you want.

mfdeveloper commented 8 years ago

Pretty awesome @devoopsme ! I created two tags for theme versions in my forked repo: https://github.com/mfdeveloper/devoops and I registered this in bower.io packages list with the name devoops-bootstrap-theme

So, if someone wish use bower + gulp with this theme, now it's possible :)