Closed ghost closed 3 years ago
:memo: Version: 1.20190225. Thank you for submitting PR #196. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.
We generate a report if there are dangerous coding constructs in your code. Please read http://nnsuite.mooo.com/nnstreamer-example/ci/repo-workers/pr-checker/196-202009241752280.88766193389893-990b885d6cd48a476a7435081b594eb5145f0888/report/pylint_result.txt.
:octocat: cibot: @dreamfinder2019, There is a newline issue. The final line of a text file should have newline character. Please resubmit your PR after fixing end of line in native/example_face_detection_tflite/nnstreamer_example_face_detection_tflite.py.
:octocat: cibot: @dreamfinder2019, One of the format checkers is failed. If you want to get a hint to fix this issue, please go to https://github.com/nnstreamer/nnstreamer-example/wiki/.
We generate a report if there are dangerous coding constructs in your code. Please read http://nnsuite.mooo.com/nnstreamer-example/ci/repo-workers/pr-checker/196-202009241816050.83868789672852-2e5206988389b11b676e6408b76c8d64231de2c4/report/pylint_result.txt.
We generate a report if there are dangerous coding constructs in your code. Please read http://nnsuite.mooo.com/nnstreamer-example/ci/repo-workers/pr-checker/196-202009241821110.86559700965881-8c3f97af5b714ce1036270bd61b31d73544a157b/report/pylint_result.txt.
:octocat: cibot: @dreamfinder2019, There is a newline issue. The final line of a text file should have newline character. Please resubmit your PR after fixing end of line in native/example_face_detection_tflite/nnstreamer_example_face_detection_tflite.py.
:octocat: cibot: @dreamfinder2019, One of the format checkers is failed. If you want to get a hint to fix this issue, please go to https://github.com/nnstreamer/nnstreamer-example/wiki/.
We generate a report if there are dangerous coding constructs in your code. Please read http://nnsuite.mooo.com/nnstreamer-example/ci/repo-workers/pr-checker/196-202009241824500.92382907867432-aab25d9348cc5272ae066ad0cb47b15b9c8545ba/report/pylint_result.txt.
:octocat: cibot: @dreamfinder2019, There is a newline issue. The final line of a text file should have newline character. Please resubmit your PR after fixing end of line in native/example_face_detection_tflite/nnstreamer_example_face_detection_tflite.py.
:octocat: cibot: @dreamfinder2019, One of the format checkers is failed. If you want to get a hint to fix this issue, please go to https://github.com/nnstreamer/nnstreamer-example/wiki/.
We generate a report if there are dangerous coding constructs in your code. Please read http://nnsuite.mooo.com/nnstreamer-example/ci/repo-workers/pr-checker/196-202009241834320.2025101184845-d33aa63e97039a8ca5597d743a3852b752856440/report/pylint_result.txt.
Could you try making this PR one commit?
We generate a report if there are dangerous coding constructs in your code. Please read http://nnsuite.mooo.com/nnstreamer-example/ci/repo-workers/pr-checker/196-202009241942140.9526219367981-a732af3c3a0ec1e382a6ec588329b1e4e5820bd0/report/pylint_result.txt.
We generate a report if there are dangerous coding constructs in your code. Please read http://nnsuite.mooo.com/nnstreamer-example/ci/repo-workers/pr-checker/196-202009252348380.42377305030823-61a8cde51f5d4442946156dc05a0c5c3358bdbca/report/pylint_result.txt.
The base python file of face detection example looks good to me at this level, but it seems that nnstreamer_example_object_detection_tflite.py would be better to be pushed at least after it works, that is if you run the file it should be able to show the video from camera (or default video)
To respond to @YongjoonSeo's point, I implemented the code for the callback function in object_detection_tflite.py and set the global variable DEBUG to True to return the detection result. The newly pushed code now provides video.
We generate a report if there are dangerous coding constructs in your code. Please read http://nnsuite.mooo.com/nnstreamer-example/ci/repo-workers/pr-checker/196-202009261948050.62978196144104-7ddd70769d9b30fe783bbb2af56252fb31aab013/report/pylint_result.txt.
LGTM
We are currently working on porting object_detection_tflite to python. At this moment, We have succeeded in reading data from the label files. More elements like bus control and registering callbacks will be implemented shortly.