search

nnstreamer / nnstreamer-example

Example applications of nnstreamer. Note that we have to enable the 'apptest" CI module in the near future.
GNU Lesser General Public License v2.1
79 stars 71 forks source link

[native] Update full functional object and face detection tflite.py #202

Closed ghost closed 4 years ago

ghost commented 4 years ago

Python version of object detection and face detection using Tflite and nnstreamer now works full functonional. Both code detects objects or face. PyCairo was used as visualization tool. For face detection, the code shows only the largest detected face in the video, while the other faces are covered with black rectangles. Right now, These two codes have not yet implemented mutex or thread-related functions.

taos-ci commented 4 years ago

:memo: Version: 1.20190225. Thank you for submitting PR #202. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

taos-ci commented 4 years ago

We generate a report if there are dangerous coding constructs in your code. Please read http://nnsuite.mooo.com/nnstreamer-example/ci/repo-workers/pr-checker/202-202009271957270.24115991592407-9f371195252232c336033d3d8049a2742ae22326/report/pylint_result.txt.

ghost commented 4 years ago

Actually, I forgot to write this. The model of face_detection.py is based on detect_face.tflite in here. (src: http://nnsuite.mooo.com/warehouse/nnmodels/) Should I make this model available for download via get_model.sh?

yeseul4072 commented 4 years ago

That's a good idea.

gichan-jang commented 4 years ago

Actually, I forgot to write this. The model of face_detection.py is based on detect_face.tflite in here. (src: http://nnsuite.mooo.com/warehouse/nnmodels/) Should I make this model available for download via get_model.sh?

I agree with @soo-ni's opinion. Please update the script. And let's add .py files in meson.build and install them in examples_install_dir.

taos-ci commented 4 years ago

We generate a report if there are dangerous coding constructs in your code. Please read http://nnsuite.mooo.com/nnstreamer-example/ci/repo-workers/pr-checker/202-202009272210200.83538603782654-db0d2ce2330739300c6423de63577007a5392a32/report/pylint_result.txt.

taos-ci commented 4 years ago

We generate a report if there are dangerous coding constructs in your code. Please read http://nnsuite.mooo.com/nnstreamer-example/ci/repo-workers/pr-checker/202-202009272218080.56309509277344-683c240b648afaab1468e0254ba224b705ede763/report/pylint_result.txt.

ghost commented 4 years ago

Actually, I forgot to write this. The model of face_detection.py is based on detect_face.tflite in here. (src: http://nnsuite.mooo.com/warehouse/nnmodels/) Should I make this model available for download via get_model.sh?

I agree with @soo-ni's opinion. Please update the script. And let's add .py files in meson.build and install them in examples_install_dir.

I didn't even think about meson.build. I'll work right away.

taos-ci commented 4 years ago

:octocat: cibot: @dreamfinder2019, There is a newline issue. The final line of a text file should have newline character. Please resubmit your PR after fixing end of line in native/example_face_detection_tflite/meson.build.

taos-ci commented 4 years ago

:octocat: cibot: @dreamfinder2019, One of the format checkers is failed. If you want to get a hint to fix this issue, please go to https://github.com/nnstreamer/nnstreamer-example/wiki/.

taos-ci commented 4 years ago

:octocat: cibot: @dreamfinder2019, There is a newline issue. The final line of a text file should have newline character. Please resubmit your PR after fixing end of line in native/example_object_detection_tensorflow_lite/meson.build.

taos-ci commented 4 years ago

:octocat: cibot: @dreamfinder2019, One of the format checkers is failed. If you want to get a hint to fix this issue, please go to https://github.com/nnstreamer/nnstreamer-example/wiki/.

taos-ci commented 4 years ago

:octocat: cibot: @dreamfinder2019, There is a newline issue. The final line of a text file should have newline character. Please resubmit your PR after fixing end of line in native/example_object_detection_tensorflow_lite/meson.build.

taos-ci commented 4 years ago

:octocat: cibot: @dreamfinder2019, One of the format checkers is failed. If you want to get a hint to fix this issue, please go to https://github.com/nnstreamer/nnstreamer-example/wiki/.

taos-ci commented 4 years ago

:octocat: cibot: @dreamfinder2019, There is a newline issue. The final line of a text file should have newline character. Please resubmit your PR after fixing end of line in native/example_object_detection_tensorflow_lite/meson.build.

taos-ci commented 4 years ago

:octocat: cibot: @dreamfinder2019, One of the format checkers is failed. If you want to get a hint to fix this issue, please go to https://github.com/nnstreamer/nnstreamer-example/wiki/.

ghost commented 4 years ago

In response to numerous fix requests, we have made the following changes:

  1. Most importantly, the updated stream and stached changes were reorganized.
  2. You can download the model for face detection using get_model.sh. Face detection models are available from the following sites. (http://nnsuite.mooo.com/warehouse/nnmodels/)
  3. As the model download url of face_detection_tflite.py was confirmed, the name of the model read from the code was changed accordingly.
  4. In README.md, the model download method is updated. But description is still in works.
  5. By registering related files in meson.builds, python files will be also installed using build. In-house Build test was successful.