search

nnstreamer / nnstreamer-example

Example applications of nnstreamer. Note that we have to enable the 'apptest" CI module in the near future.
GNU Lesser General Public License v2.1
78 stars 71 forks source link

[Android] Add functions of autocapture to run in android Activities #225

Closed park-sang-hyun closed 4 years ago

park-sang-hyun commented 4 years ago

[Edit] nnstreamer-jni.h : Add data structure to contain conditions for autocapture. [Edit] nnstreamer-jni.c : Add 'NativeDeleteLineAndLabel', 'NativeInsertLineAndLabel', 'NativeGetCondition', 'NativeGetAutoCapture' functions based on jni. [Edit] nnstreamer-ex.cpp : Implement 'NativeDeleteLineAndLabel', 'NativeInsertLineAndLabel', 'NativeGetCondition', 'NativeGetAutoCapture' functions.

When objects that meet the conditions are visible on the screen, can take picture automatically. When in autocapture mode, can erase the label's name and line so that only objects can appear in the picture taken.

taos-ci commented 4 years ago

:memo: Version: 1.20190225. Thank you for submitting PR #225. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

Soyeong-k-1230 commented 4 years ago

LGTM!

macaron10 commented 4 years ago

LGTM!

Joojihwan commented 4 years ago

LGTM

taos-ci commented 4 years ago

We generate a report if there are dangerous coding constructs in your code. Please read http://nnsuite.mooo.com/nnstreamer-example/ci/repo-workers/pr-checker/225-202010122312210.96337604522705-48a2504d1b3e2e827c0de4ec8c577541e455284f/report/.

taos-ci commented 4 years ago

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://nnsuite.mooo.com/nnstreamer-example/ci/repo-workers/pr-checker/225-202010122312210.96337604522705-48a2504d1b3e2e827c0de4ec8c577541e455284f/report/.

anyj0527 commented 4 years ago

@park-sang-hyun Please make this as a single commit PR

park-sang-hyun commented 4 years ago

Thank you for your answer Mentor... I've tried... But I don't know how, so I'm going to get a fork again and try to pr.

zhoonit commented 4 years ago

Thank you for your answer Mentor... I've tried... But I don't know how, so I'm going to get a fork again and try to pr.

You don't need to fork again and make another PR.

You need to do something like 

git rebase -i HEAD~3
(squash everything with resolving conflicts)
git push -f
park-sang-hyun commented 4 years ago

I tried the rebase ~i HEAD~3 and it stopped because even the native commitments were canceled. Why is that...?

zhoonit commented 4 years ago

What does git status say?

park-sang-hyun commented 4 years ago

When rebase i HEAD~3 was attempted, about 10 commits were unstaged, including 'native' and 'android'

zhoonit commented 4 years ago

Commits cannot be 'unstaged'. I think you are having confusions with some terms. DM me in the slack :)

park-sang-hyun commented 4 years ago

Thank you for your advice... Can I try it again and if there's something that doesn't work, can I capture it and ask you again...?

zhoonit commented 4 years ago

Thank you for your advice... Can I try it again and if there's something that doesn't work, can I capture it and ask you again...?

Sure. Please read through https://git-scm.com/book/en/v2/

or at least refer to https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History

park-sang-hyun commented 4 years ago

Thank you very much!

taos-ci commented 4 years ago

We generate a report if there are dangerous coding constructs in your code. Please read http://nnsuite.mooo.com/nnstreamer-example/ci/repo-workers/pr-checker/225-202010132220590.49855804443359-e5b404b4d60f968cd5f636447ded5bb057551cc8/report/pylint_result.txt.

park-sang-hyun commented 4 years ago

While studying the link that my mentor gave me, while I was using reset and database together, I pushed and the pull request was forced to close. I'm so sorry.....