search

nnstreamer / nnstreamer-example

Example applications of nnstreamer. Note that we have to enable the 'apptest" CI module in the near future.
GNU Lesser General Public License v2.1
77 stars 72 forks source link

[Android] Add style transfer example using java api #258

Closed eu1jun closed 3 years ago

eu1jun commented 3 years ago

This is a very simple example to show how to use NNStreamer APIs and Android Camera API to utilize the style transfer model.

Signed-off-by: EJ Jung proej11741@gmail.com

Self evaluation:

  1. Build test: [*]Passed [ ]Failed [ ]Skipped
  2. Run test: [*]Passed [ ]Failed [ ]Skipped
taos-ci commented 3 years ago

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #258. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

taos-ci commented 3 years ago

:octocat: cibot: @Ofiun, The last line of a text file must have a newline character. Please append a new line at the end of the line in android/example_app/style-transfer-with-nnstreamer-java-api/.idea/gradle.xml.

taos-ci commented 3 years ago

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

taos-ci commented 3 years ago

:octocat: cibot: @Ofiun, The last line of a text file must have a newline character. Please append a new line at the end of the line in android/example_app/style-transfer-with-nnstreamer-java-api/.idea/gradle.xml.

taos-ci commented 3 years ago

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

taos-ci commented 3 years ago

:octocat: cibot: @Ofiun, The last line of a text file must have a newline character. Please append a new line at the end of the line in android/example_app/style-transfer-with-nnstreamer-java-api/.idea/gradle.xml.

taos-ci commented 3 years ago

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

taos-ci commented 3 years ago

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

jaeyun-jung commented 3 years ago

Can you remove unnecessary files? IMO, yo dont need to upload files local.properties, .settings, .classpath, .idea. Also, when using nnstreamer.aar, .java files under src/main/java/org/nnsuite/nnstreamer are unnecessary.

eu1jun commented 3 years ago

@jaeyun-jung Sorry, I did not know you commented.. I will check what you commented and request again as a new PR.

jaeyun-jung commented 3 years ago

@Ofiun local.properties, .settings, .classpath, .idea These files would be generated when importing project in android-studio. (local setting on your pc) Also, after copying NNStreamer API library into libs directory, java files in org/nnsuite/nnstreamer (e.g., NNStreamer.java, TensorsInfo.java, ...) are unecessary, it already included in NNStreamer API library.

eu1jun commented 3 years ago

@jaeyun-jung I'm not sure about the second part. So is it okay for me to just upload nnstreamer/sample/MainActivity.java without four java files in the same nnstreamer/ folder?

jaeyun-jung commented 3 years ago

in build.gradle implementation fileTree(include: ['*.aar'], dir: 'libs')

This will import .aar file in libs directory (NNStreamer API library is there), so I think you can build and run this project only with MainActivity.java.

eu1jun commented 3 years ago

Thank you for your explanation! I'll request a new one without them!