search

nnstreamer / nnstreamer-example

Example applications of nnstreamer. Note that we have to enable the 'apptest" CI module in the near future.
GNU Lesser General Public License v2.1
79 stars 71 forks source link

[Example] Fix java api examples @open sesame 4/25 12:38 #285

Closed makesource closed 2 years ago

makesource commented 2 years ago

There are two major problems in example projects.

  1. Registration of setPreviewCallback was not worked in my recent Android10 device. I fixed it to register callback immediately after setting the preview display.
  2. Current gstreamer pipeline in style-transfer-with-nnstreamer-java-api causes E/GStreamer+videoconvert: 0:00:01.553407343 0x7c60d44de0 ../gst/videoconvert/gstvideoconvert.c:618:gst_video_convert_set_info:<videoconvert1> input and output formats do not match error in GStreamer 1.20.0. I don't know the exact reasons but after I removed videoconvert in the pipeline, it worked well.

Self evaluation:

  1. Build test: [ ]Passed [ ]Failed [*]Skipped
  2. Run test: [ ]Passed [ ]Failed [* ]Skipped
taos-ci commented 2 years ago

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #285. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

taos-ci commented 2 years ago

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

jaeyun-jung commented 2 years ago

LGTM. Please add git signing on your PR.

makesource commented 2 years ago

@jaeyun-jung I've updated it to use git signing, but ci doesn't seem to catch it properly. Could you retry the ci build? Thanks :)

anyj0527 commented 2 years ago

@makesource CI complained about no commit body (not commit title). You may write commit body for each commit (more that 5 words)

makesource commented 2 years ago

@anyj0527 Thanks for letting me know. I updated the commits.