search

nnstreamer / nnstreamer-example

Example applications of nnstreamer. Note that we have to enable the 'apptest" CI module in the near future.
GNU Lesser General Public License v2.1
77 stars 72 forks source link

Add eslint for code linting #342

Closed niley7464 closed 1 month ago

niley7464 commented 2 months ago

This PR adds eslint config and applies it.

taos-ci commented 2 months ago

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #342. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

niley7464 commented 2 months ago 
nnstreamer-example/Tizen.web/ImageClassificationOffloading/js/main.js
   83:24  error  'tizen' is not defined              no-undef
   91:17  error  'tizen' is not defined              no-undef
  113:22  error  'tizen' is not defined              no-undef
  133:15  error  'tizen' is not defined              no-undef
  136:23  error  'tizen' is not defined              no-undef
  195:9   error  'tizen' is not defined              no-undef
  196:16  error  'ignore' is defined but never used  no-unused-vars
  196:24  error  Empty block statement               no-empty

nnstreamer-example/Tizen.web/ImageClassificationOffloading/js/utils.js
  15:32  error  'reject' is defined but never used  no-unused-vars
  16:5   error  'tizen' is not defined              no-undef
  28:32  error  'reject' is defined but never used  no-unused-vars
  29:5   error  'tizen' is not defined              no-undef
  71:19  error  'tizen' is not defined              no-undef

nnstreamer-example/Tizen.web/ImageClassificationPipeline/js/main.js
   56:17  error  'tizen' is not defined              no-undef
   70:22  error  'tizen' is not defined              no-undef
   85:17  error  'tizen' is not defined              no-undef
  109:9   error  'tizen' is not defined              no-undef
  110:16  error  'ignore' is defined but never used  no-unused-vars
  110:24  error  Empty block statement               no-empty
  121:21  error  'tizen' is not defined              no-undef
  126:29  error  'tizen' is not defined              no-undef

nnstreamer-example/Tizen.web/ImageClassificationSingleShot/js/main.js
   56:17  error  'tizen' is not defined              no-undef
   71:15  error  'tizen' is not defined              no-undef
   88:9   error  'tizen' is not defined              no-undef
   89:16  error  'ignore' is defined but never used  no-unused-vars
   89:24  error  Empty block statement               no-empty
  100:29  error  'tizen' is not defined              no-undef

There are lots of error left which could not fixed by --fix option. I just used recommended configs, so we need to set specific option for Tizen.web too.