Closed heka1024 closed 2 months ago
:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2545. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.
:octocat: cibot: @heka1024, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2545-202404150909200.1524920463562-f83a0b89ae343d65d820be010f18fe5dcc54599a/.
Please rebase:
$ git checkout main
$ git pull ${FILL_upstream_name} main
$ git checkout activation-softplus
$ git rebase main
$ git push ${FILL_your_fork_name} HEAD -f
I found this PR raises error when building with
meson build -Denable-fp16=true
@heka1024
Could you please take a look?
@skykongkong8 I think precision could be a problem. Could you give me a link of failure log?
@heka1024 Nope it's build fail, not unittest fail.
error: converting to ‘_Float16’ from ‘float’ with greater conversion rank [-Werror]
364 | return static_cast<T>(log(1 + exp_util<T>(beta * x)) / beta);
error: converting to ‘_Float16’ from ‘float’ with greater conversion rank [-Werror]
374 | return sigmoid<T>(beta * x);
| ~~~~~~~~~~^~~~~~~~~~
../nntrainer/layers/acti_func.h:269:52: note: initializing argument 1 of ‘static T nntrainer::ActiFunc::sigmoid(T) [with T = _Float16]’
269 | template <typename T = float> static T sigmoid(T x) {
|
Try below to generate the error above:
cd ~/nntrainer/
meson build -Denable-fp16=true
cd ./build
ninja
Think your commit needs some fixes. Could you create a new PR to fix this issue?
@heka1024 This issue is resolved via #2557 I would like to personally recommend you to check for fp16 build case as well next time!
Self evaluation:
Signed-off-by: heka1024 heka1024@gmail.com