search

nnstreamer / nntrainer

NNtrainer is Software Framework for Training Neural Network Models on Devices.
Apache License 2.0
144 stars 73 forks source link

[GPU/OpenCL] Initial version of SwiGLU Layer with OpenCL ops #2624

Closed niket-agarwal closed 3 months ago

niket-agarwal commented 3 months ago

Added initial version of SwiGLU Layer for GPU. This is a basic implementation using naive kernel.

Changes added with this PR:

Signed-off-by: Niket Agarwal niket.a@samsung.com

taos-ci commented 3 months ago

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2624. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

taos-ci commented 3 months ago

:octocat: cibot: @niket-agarwal, nntrainer/layers/cl_layers/swiglu_cl.h does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

taos-ci commented 3 months ago

:octocat: cibot: @niket-agarwal, nntrainer/layers/cl_layers/swiglu_cl.h does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

taos-ci commented 3 months ago

:octocat: cibot: @niket-agarwal, The last line of a text file must have a newline character. Please append a new line at the end of the line in nntrainer/layers/cl_layers/swiglu_cl.h.

myungjoo commented 3 months ago

Your file format is not consistent. Refer to the static check: https://github.com/nnstreamer/nntrainer/actions/runs/9417608692/job/25967822229?pr=2624

Maybe you are using "MS-DOS" type of text file. Please use Linux/Unix type. The utility "dos2unix" will easily fix this. You may need to configure your code editor properly to prevent this issue, too.

myungjoo commented 3 months ago

Please add proper doxygen tags, too. Without them, we are required to add doxygen tags for every class and function later right before a milestone release, which is going to be a huge task if we don't add tags for each commit. Please add them at each commit when you write a new function or class:

[ERROR] File name: api/ccapi/include/layer.h, 300 line, SwigluCl(const function needs @brief tag 

[ERROR] File name: nntrainer/layers/cl_layers/swiglu_cl.h, 98 line, void function needs @brief tag 

[ERROR] File name: nntrainer/layers/cl_layers/swiglu_cl.h, 101 line, void function needs @brief tag 

[ERROR] File name: nntrainer/layers/cl_layers/swiglu_cl.h, 104 line, void function needs @brief tag
taos-ci commented 3 months ago

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

myungjoo commented 3 months ago
  1. Please rebase to the recent main.
  2. Any big commit or PR will suffer longer time to merge. In the next time, please try to submit smaller PRs.