nnsvs / nnsvs

Neural network-based singing voice synthesis library for research
https://nnsvs.github.io
MIT License
687 stars 81 forks source link

unnecessary process in gen.py #64

Closed oatsu-gh closed 2 years ago

oatsu-gh commented 2 years ago

https://github.com/r9y9/nnsvs/blob/c69566f32c3799f9c0c0a76cc1f48175be9c653a/nnsvs/gen.py#L285-L292

it seems L285 in nnsvs.gen.py can be removed and can be changed from

 windows = get_windows(num_windows) 

 # Apply MLPG if necessary 
 if np.any(has_dynamic_features): 
     static_stream_sizes = get_static_stream_sizes( 
         stream_sizes, has_dynamic_features, len(windows)) 
 else: 
     static_stream_sizes = stream_sizes

to

 # Apply MLPG if necessary 
 if np.any(has_dynamic_features): 
     static_stream_sizes = get_static_stream_sizes( 
         stream_sizes, has_dynamic_features, num_windows) 
 else: 
     static_stream_sizes = stream_sizes
r9y9 commented 2 years ago

Thanks for your suggestion. You are right; I will fix it soon.