no-comment / AppStore-Connect-Widget

Open source AppStore sales monitor with widget
MIT License
114 stars 14 forks source link

Finish button not working #20

Closed techinpark closed 1 year ago

techinpark commented 2 years ago
mikakruschel commented 2 years ago

Hey, please make sure that you also entered a name for the api key on the page before.

techinpark commented 2 years ago

Hey, please make sure that you also entered a name for the api key on the page before.

yes. all done 😅

techinpark commented 2 years ago

@mikakruschel any solutions?

mikakruschel commented 2 years ago

The only conditions for the finish button to be disabled are: name.isEmpty || issuerID.isEmpty || keyID.isEmpty || key.isEmpty || vendor.isEmpty. So if you have everything filled out there shouldn't be anything stopping you from adding the key. I have added some better error handling (marking empty fields with a red border) and will upload and submit the new build to TestFlight shortly. If you already using ACWidget via TestFlight you will receive the update as soon as the build is reviewed.

techinpark commented 2 years ago

Thanks! I looking forward to new build version 😄

techinpark commented 2 years ago

@mikakruschel version 1.3 still not working :/

mikakruschel commented 2 years ago

What exactly do you mean by the finish button not working? Is it disabled(grayed out) or does nothing happen when you click it?

techinpark commented 2 years ago

@mikakruschel nothing happen when click it.

mikakruschel commented 2 years ago

Hey @techinpark, I don't know what to do at this point because I can't reproduce any problem 🤷‍♂️. Maybe if you have some time you could clone this repo and debug it yourself.

techinpark commented 2 years ago

@mikakruschel I found the problem and solved it. when no have access for Sales and Report finish button is not working. thanks for good your work!

mikakruschel commented 2 years ago

Glad to hear that.

Drusy commented 2 years ago

The same happens to me the button is enabled (blue) but the tap does nothing. No loading, no error, no success. I think an error message would be nice :) I chose finance on my key. It should be reports?

EDIT: Also tried with a "Report & Sales" key, and the finish button still does nothing. I am adding a second key (for another AppStoreConnect account), is the issue only when adding a second key @mikakruschel ?

EDIT 2: If I add wrong information, then I have an error "Invalid Key", if I provide the expected information, nothing happens.

Is there any network call on this button using the key ? Another information, no app is published yet, it's a fresh account.

Drusy commented 2 years ago

After cloning and running the project, I can confirm that the issue is server side, it returns a 500, probably because the account is new

500
Optional("{\r\n\t\"errors\": [{\r\n\t\t\"status\": \"500\",\r\n\t\t\"code\": \"UNEXPECTED_ERROR\",\r\n\t\t\"title\": \"An unexpected error occurred.\",\r\n\t\t\"detail\": \"An unexpected error occurred on the server side. If this issue continues, contact us at https://developer.apple.com/contact/.\"\r\n\t}]\r\n}")

Anyway, I think it would be nice to add

Currently, only invalidCredentials is managed, and every other error makes the button responseless

                let apiErr: APIError = (err as? APIError) ?? .unknown
                if apiErr == .invalidCredentials {
                    alert = .invalidKey
                }
mikakruschel commented 2 years ago

Hey @Drusy, thanks for investigating this problem! We will fix this issue in our next big update.

Drusy commented 2 years ago

Sorry currently travelling I have no time to make a proper pull request. Looking forward for the next update 😃

cameronshemilt commented 1 year ago

Hey @techinpark & @Drusy,

we have rewritten ACWidget completely from the ground up into a new app called Trendly. You can check it out at gettrendly.app. This unfortunately means that we will no longer work on ACWidget.