search

no-context / moo

Optimised tokenizer/lexer generator! 🐄 Uses /y for performance. Moo.
BSD 3-Clause "New" or "Revised" License
817 stars 65 forks source link

Fix unicode checks for fallbacks #124

Closed moranje closed 5 years ago

moranje commented 5 years ago

There is no way to provide a unicode fallback pattern currently.

Error: If one rule is /u then all must be

tjvr commented 5 years ago

Thanks! Would you be able to add a test case for this?

I'm not sure why we're marking the fallback token as unicode: true in your patch; I don't think this will have any effect.

Sent with GitHawk

moranje commented 5 years ago

I'll add a test case later tonight. You are right, RegExp.prototype.unicode is readonly. I'll fix that too.

Martien

Op ma 22 apr. 2019 17:17 schreef Tim Radvan notifications@github.com:

Thanks! Would you be able to add a test case for this?

I'm not sure why we're marking the fallback token as unicode: true in your patch; I don't think this will have any effect.

Sent with GitHawk http://githawk.com

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/no-context/moo/pull/124#issuecomment-485446862, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFCXIBD5QX3JWD6NGHISIDPRXJJDANCNFSM4HHP35AA .