Prettier Errors

[tjvr]

Invalid syntax: line 1: 'baa'

Also, attach line and col to the Error we throw—(is this useful?)

[nathan]

Confusing if you have a syntax error at the end of a line, since it would say the line was blank.

(is this useful?)

Yes, because I like to generate error messages that look like this:

Error: invalid syntax at /some/file.ext:12:3

  totally valid `syntax`
                ^

Probably makes sense to include offset too.

[tjvr]

Yes, because I like to generate error messages that look like this

Right. But you could already do that by defining an error rule.

[nathan]

Fair enough. Probably not, then.

[bates64]

Please add line and col anyway?

[tjvr]

@nanalan Why? As explained above, you can define an error token.

[bates64]

Actually, that's a good point 😜 Error tokens do look like the way to go!

[tjvr]

Confusing if you have a syntax error at the end of a line, since it would say the line was blank.

What do you propose? Special-case that -- Invalid end of line?

[nathan]

I'd be inclined to say just extract the whole line, scanning backward if possible.

[tjvr]

@nathan Done!

[tjvr]

(Ignore the failed check—that should be fixed now.)