no-context / moo

Optimised tokenizer/lexer generator! 🐄 Uses /y for performance. Moo.
BSD 3-Clause "New" or "Revised" License
821 stars 65 forks source link

Fix Lexer#has so it works with states and keywords #51

Closed deltaidea closed 7 years ago

deltaidea commented 7 years ago

Also add fancy tests.

Closes #50, closes #47.

deltaidea commented 7 years ago

Anything I could change or fix here?

tjvr commented 7 years ago

I'll have a look this evening—sorry! :-)

tjvr commented 7 years ago

This looks great, thanks :D

I tweaked the style of the code slightly—I gave you bad advice the first time round, sorry about that—but I'm really happy we fixed this, and I like how well it's tested!

deltaidea commented 7 years ago

Sure! It's important to keep the style consistent and not in the way of performance.

Thanks for the invite! I might not have much time, but I'd be happy to help with maintenance.