Throw error for no matching state

no-context / moo

Optimised tokenizer/lexer generator! 🐄 Uses /y for performance. Moo.

BSD 3-Clause "New" or "Revised" License

821 stars 65 forks source link

Throw error for no matching state #60

Closed juliankrispel closed 7 years ago

juliankrispel commented 7 years ago

[x] Throw an error when there is no matching state for a state transition.

deltaidea commented 7 years ago

Would be better to check for this during compilation once. Otherwise, 👍

juliankrispel commented 7 years ago

Ha. Looking at the tests it should already do that. Wondering why there wasn't an error thrown... let me check

Julian Krispel UI Engineer & Consultant http://reactrocket.com +447988116178

On Jul 21, 2017, at 7:57 AM, Nikita Litvin notifications@github.com wrote:

Would be better to check for this during compilation once. Otherwise, 👍

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

tjvr commented 7 years ago

Yeah, moo should already warn you. Would you like to send a bug report? Can you provide steps to reproduce this? :)

nathan commented 7 years ago

Agreed. This is unnecessary, since we do the check at compile time and we don't like runtime costs.

tjvr commented 7 years ago

There is, as it turns out, a bug in the check. Fixed in b09251f.

nathan commented 7 years ago

Oops. Sorry.

EDIT: Also double oops because I didn't check the rest of my notifications first.

tjvr commented 7 years ago

No worries :-)

Clearly I should review your PRs more carefully, my mistake ;-)