search

no-mayo / today-i-learned

1 stars 8 forks source link

Users should be able to destroy any saved user data #20

Open louisebolden opened 7 years ago

louisebolden commented 7 years ago

When a user logs in with Twitter, we save their name into our Firebase.

Users should be able to easily find & click a 'Delete Account' button that would remove that data, as well as any learns that they'd saved.

jpmaHub commented 6 years ago

Hi @louiseswift,

I have completed the two beginner level issues and sent you a pull request. I am working on this one.

  1. My function is not defined onClick in index.html. I have added a new method called removerUser in index.js

  2. I couldn't run the webpack. I get Microsoft JScript Compile Error when I did node_module step. When I try the webpack --progress --watch. I get webpack not recognized.

louisebolden commented 6 years ago

Hi @jpmaHub - thanks for your pull requests so far!

To give the best answer to your question here, I should review the codebase a little. I'll hopefully get some time for this later this week.

Can I just check whether you've been successful at running webpack in a project on your machine before? That would give me a good hint about where to start investigating.

Also - are you running Windows?

jpmaHub commented 6 years ago

Hi, @louiseswift I am running on windows and I couldn't run the webpack command at all. I never run the wbepack before. I just did the changes on the project without doing the webpack command step.