search

no-stack-dub-sack / cs-playground-react

In-Browser Algorithm and Data Structures Practice
http://cs-playground-react.surge.sh/
MIT License
520 stars 91 forks source link

Replaced terse variable usages in favor of their full qualifiers #21

Closed supamunkey closed 6 years ago

supamunkey commented 6 years ago

What's new? 💃

Currently, variables are declared somewhat inconsistently and the usage of val and el as variable names can be a bit confusing for someone coming from another programming-language. Specifically, val is an actual keyword in other languages -- take Kotlin, for example.

To avoid confusion, these variable usages are replaced with their full name qualifiers: value and element.

no-stack-dub-sack commented 6 years ago

Thanks @supamunkey! I learned something new today - I've never even heard of Kotlin. A Java interoperable language that compiles down to JavaScript - how bout that? 🆒 😎

I'm not terribly worried about people coming from this language getting confused with val, as JavaScript is far more likely to be someone's intro language, plus the context surrounding it, but all the same, I've thought of this myself, and is good practice, so I don't at all disagree!

Thanks for the PR again! You're officially the most prolific contributor now besides myself 😄

no-stack-dub-sack commented 6 years ago

P.S. sorry for the late reply! Been quite busy over the last several days working on the migration of the new React curriculum in to freeCodeCamp's codebase.

supamunkey commented 6 years ago

Re: No biggie; I haven't had internet since opening this PR 🤣