search

no-stack-dub-sack / cs-playground-react

In-Browser Algorithm and Data Structures Practice
http://cs-playground-react.surge.sh/
MIT License
520 stars 91 forks source link

Feat/rev string #49

Closed dliberat closed 6 years ago

dliberat commented 6 years ago

Added a "Reverse a string" challenge. Includes a couple of very simple tests. The contributing guidelines were very clear and easy to follow! I would, however, appreciate any feedback on things I may have missed or done incorrectly.

no-stack-dub-sack commented 6 years ago

Hey @garroadran, sweet! About to head out for the night now, but I'll take a look tomorrow first thing. At first glance it looks great, but I'll pull it down tomorrow. Thanks for the PR!

no-stack-dub-sack commented 6 years ago

@garroadran this looks perfect, thanks! Glad the docs were helpful. You hit all the points including adding the solution to the app tests (and the solution you chose is a great one).

Great job, and thanks for pitching in! Unfortunately it doesn't seem like the post on FCC is getting a lot of love, but I still hope to make something out of this and every bit of help counts 👍

Feel free to keep the project in mind if you ever have some free time to contribute some more, or if you know of anyone else who might like to get some open source contributions under their belt!

no-stack-dub-sack commented 6 years ago

working towards #19