search

no-stack-dub-sack / cs-playground-react

In-Browser Algorithm and Data Structures Practice
http://cs-playground-react.surge.sh/
MIT License
520 stars 91 forks source link

Binary tree search fix #84

Closed mansisce closed 5 years ago

mansisce commented 5 years ago

Please test this once. Is there any test cases to run?

no-stack-dub-sack commented 5 years ago

@mansisce also, there is a test suite you can run with yarn test which should test all the solutions against the built in tests, however it might not be working properly right now. You can give it a try, but as long as the solution is manually passing the tests in the UI (which it should, I've tested it), let's not worry about it for now. There's no CI which will block it from being merged.

mansisce commented 5 years ago

@no-stack-dub-sack I've resolved the issue. Please merge it now. Sorry for late response.

mansisce commented 5 years ago

@no-stack-dub-sack please merge this

no-stack-dub-sack commented 5 years ago

@mansisce that one took a while but glad we got it fixed, thanks! Sorry for the delayed merge, been busy the last couple of months starting a family :-)

no-stack-dub-sack commented 5 years ago

@mansisce changes deployed :+1: :smile: