noaa-afsc-mace / WinterGOAHistorical

Winter GOA preselectivity data package
https://noaa-afsc-mace.github.io/WinterGOAHistorical/
0 stars 0 forks source link

"Installed package size" note when I check #1

Open abigailatsea opened 6 months ago

abigailatsea commented 6 months ago

Hi @mike-levine - I stripped this package down to a true data package, and I will slowly build it up from here to include the mechanisms to get the data- solid advice from you on that! I'm putting this in an issue so I don't forget about it. I'd love your take on this, as I'm wondering if I need to solve it, because it is a data package, so one might expect it to take up space.

Here's the note I'm getting: ❯ checking installed package size ... NOTE installed size is 22.8Mb sub-directories of 1Mb or more: data 20.2Mb

The clearest answer to my exact problem is here: https://stackoverflow.com/questions/53819970/r-package-libs-directory-too-large-after-compilation-to-submit-on-cran And the answer that's given is: "You don't "solve" this. It is a NOTE, ie less than a WARNING or ERROR. Hundreds of C++ based packages have the same, including Rcpp itself. It will not stop CRAN."

Do we think that's true?? Should I proceed? I had a warning because I hadn't compressed the data, so I went ahead and compressed it, and explained the kind of compression I'd used in my Description file. Now I'm down to just this note.

mike-levine commented 6 months ago

Hey! On leave but checking in on a few things. I think you are fine to store data in the usual r data structures (.rda I think? Can’t remember off the too of my head) and ignore this warning-I get the same, if you store data it’s inevitable! And only matters for CRAN, which we’ll never need. I don’t do any fancier compressions than using standard r data structures.

All sounds good!

On Tuesday, June 4, 2024, Abigail McCarthy @.***> wrote:

Hi @mike-levine https://github.com/mike-levine - I stripped this package down to a true data package, and I will slowly build it up from here to include the mechanisms to get the data- solid advice from you on that! I'm putting this in an issue so I don't forget about it. I'd love your take on this, as I'm wondering if I need to solve it, because it is a data package, so one might expect it to take up space.

Here's the note I'm getting: ❯ checking installed package size ... NOTE installed size is 22.8Mb sub-directories of 1Mb or more: data 20.2Mb

The clearest answer to my exact problem is here: https://stackoverflow.com/questions/53819970/r-package- libs-directory-too-large-after-compilation-to-submit-on-cran And the answer that's given is: "You don't "solve" this. It is a NOTE, ie less than a WARNING or ERROR. Hundreds of C++ based packages have the same, including Rcpp itself. It will not stop CRAN."

Do we think that's true?? Should I proceed? I had a warning because I hadn't compressed the data, so I went ahead and compressed it, and explained the kind of compression I'd used in my Description file. Now I'm down to just this note.

— Reply to this email directly, view it on GitHub https://github.com/abigailatsea/WinterGOAHistorical/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEGOO5B7UQXT7DQX6BNHVSLZFYR7DAVCNFSM6AAAAABIZJNN26VHI2DSMVQWIX3LMV43ASLTON2WKOZSGMZTIMZUGU2DSOI . You are receiving this because you were mentioned.Message ID: @.***>

-- Mike Levine (he/him/his) Research Fishery Biologist NOAA\NMFS\AFSC 802-318-0881; 206-526-6417