search

noaa-afsc-mace / WinterGOAHistorical

Winter GOA preselectivity data package
https://noaa-afsc-mace.github.io/WinterGOAHistorical/
0 stars 0 forks source link

WinterGOAHistorical::query_run_time parameter #3

Closed mike-levine closed 2 weeks ago

mike-levine commented 2 months ago

Hey @abigailatsea Minor (very minor) request: Would you mind changing the name of the value query_run_time that is included with your data? There's nothing wrong with it, but it causes a conflict with the reports where you have two query_run_time objects, and its hard to know which is which. Maybe change to historical_query_run_time or something?

abigailatsea commented 2 weeks ago

Hi Mike- I'm trying to fix this but cannot seem to get the package to rebuild with that renamed file. Stay tuned.

abigailatsea commented 2 weeks ago

Hey @mike-levine - Fixed the variable name so it's now "historical_query_run_time". Can you pull and test for me please?

mike-levine commented 2 weeks ago

Yep! I re-installed package and that is now in there. Thanks!

abigailatsea commented 2 weeks ago

yay!